From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1384 invoked by alias); 28 Jun 2010 19:51:04 -0000 Received: (qmail 1376 invoked by uid 22791); 28 Jun 2010 19:51:04 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Jun 2010 19:50:59 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5SJoVmA032513 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 28 Jun 2010 15:50:31 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5SJoSEQ019208 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 28 Jun 2010 15:50:30 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o5SJoSNZ019954; Mon, 28 Jun 2010 21:50:28 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o5SJoRUt019953; Mon, 28 Jun 2010 21:50:27 +0200 Date: Mon, 28 Jun 2010 19:51:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [patch] testsuite: Error on trailing newlines Message-ID: <20100628195027.GA19297@host0.dyn.jankratochvil.net> References: <20100602214003.GA31569@host0.dyn.jankratochvil.net> <20100602214350.GC3019@adacore.com> <20100602223124.GA2335@host0.dyn.jankratochvil.net> <20100602230235.GH3019@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100602230235.GH3019@adacore.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00652.txt.bz2 On Thu, 03 Jun 2010 01:02:35 +0200, Joel Brobecker wrote: > > * lib/gdb.exp (gdb_test_multiple): Error on trailing newlines. > > This part is OK as far as I am concerned, but let's hold off on it > for a couple of days, to see if others have any comment about it. After 25 days going to check it in a day (or upon approval). Changed the message text. Rechecked no regressions on {x86_64,x86_64-m32,i686}-fedora13-linux-gnu. Thanks, Jan gdb/testsuite/ 2010-06-28 Jan Kratochvil Joel Brobecker * lib/gdb.exp (gdb_test_multiple): Error on trailing newlines. --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -573,6 +573,10 @@ proc gdb_test_multiple { command message user_code } { set message $command } + if [string match "*\[\r\n\]" $command] { + error "Invalid trailing newline in \"$message\" test" + } + # TCL/EXPECT WART ALERT # Expect does something very strange when it receives a single braced # argument. It splits it along word separators and performs substitutions.