From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1180 invoked by alias); 28 Jun 2010 15:57:43 -0000 Received: (qmail 1092 invoked by uid 22791); 28 Jun 2010 15:57:42 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Jun 2010 15:57:37 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5SFvaLc023415 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 28 Jun 2010 11:57:36 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5SFvYqJ016112 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 28 Jun 2010 11:57:35 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o5SFvXkd006175; Mon, 28 Jun 2010 17:57:33 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o5SFvXQg006174; Mon, 28 Jun 2010 17:57:33 +0200 Date: Mon, 28 Jun 2010 15:57:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [patch] Delete FIELD_LOC_KIND_DWARF_BLOCK, unused. Message-ID: <20100628155732.GA5597@host0.dyn.jankratochvil.net> References: <20100627165540.D944984613@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100627165540.D944984613@ruffy.mtv.corp.google.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00633.txt.bz2 On Sun, 27 Jun 2010 18:55:40 +0200, Doug Evans wrote: > This patch is strictly cleanup. > It deletes FIELD_LOC_KIND_DWARF_BLOCK as it is unused. Just a background for it why it was introduced and why it is no longer needed even for future additions. It has been introduced a s part of VLA (Variable Length Arrays) patch series importing which I never finished that time (and should start again soon). Re: [patch] static_kind -> bit0, bit1 [Re: [gdb] Fortran dynamic arrays] http://sourceware.org/ml/gdb-patches/2008-09/msg00425.html # The first goal, as I understand it, is to be able to extend range # types so that the bounds can be DWARF blocks. Just in the meantime this FIELD_LOC_KIND_* is no longer used for array bounds as new TYPE_RANGE_DATA different field of the union in the former place of TYPE_FIELDS has been introduced: [COMMIT] 64-bit range types in GDB http://sourceware.org/ml/gdb-patches/2009-12/msg00181.html The current FSF GDB HEAD uses just `LONGEST low, high;' for the bounds. archer-jankratochvil-vla therefore has ported this FIELD_LOC_KIND_DWARF_BLOCK to: struct { union { LONGEST constant; struct dwarf2_locexpr_baton *dwarf_block; struct { struct dwarf2_loclist_baton *loclist; struct type *type; } dwarf_loclist; } u; enum range_bound_kind { RANGE_BOUND_KIND_CONSTANT, RANGE_BOUND_KIND_DWARF_BLOCK, RANGE_BOUND_KIND_DWARF_LOCLIST } kind; } /* Low bound of range. */ low, /* High bound of range. */ high, /* Byte stride of range. */ byte_stride; But that is not currently submitted for a review. > I will commit this in a few days if there are no objections. BTW I agree. Thanks, Jan