From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17692 invoked by alias); 25 Jun 2010 22:04:12 -0000 Received: (qmail 17641 invoked by uid 22791); 25 Jun 2010 22:04:12 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,TW_CP,TW_XS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.17.167) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Jun 2010 22:04:05 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.1/8.13.1) with ESMTP id o5PM42CB018672 for ; Fri, 25 Jun 2010 22:04:02 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5PM42ZC1102078 for ; Sat, 26 Jun 2010 00:04:02 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o5PM42Cn019442 for ; Sat, 26 Jun 2010 00:04:02 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id o5PM40i4019435; Sat, 26 Jun 2010 00:04:00 +0200 Message-Id: <201006252204.o5PM40i4019435@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Sat, 26 Jun 2010 00:04:00 +0200 Subject: Re: [patch, spu] Detect OpenCL program executables To: jan.kratochvil@redhat.com (Jan Kratochvil) Date: Fri, 25 Jun 2010 22:04:00 -0000 From: "Ulrich Weigand" Cc: ken@linux.vnet.ibm.com (Ken Werner), gdb-patches@sourceware.org In-Reply-To: <20100625200421.GA25517@host0.dyn.jankratochvil.net> from "Jan Kratochvil" at Jun 25, 2010 10:04:21 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00606.txt.bz2 Jan Kratochvil wrote: > On 32bit hosts with --enable-64-bit-bfd --enable-targets=all it causes: > > solib-spu.c: In function 'append_ocl_sos': > solib-spu.c:130: error: format '%lx' expects type 'long unsigned int', but argument 4 has type 'CORE_ADDR' Oops, sorry for overlooking that. Fixed by using hex_string just like in spu_current_sos. Tested on powerpc64-linux, committed to mainline. Bye, Ulrich ChangeLog: * solib-spu.c (append_ocl_sos): Fix xsnprintf statement for hosts where CORE_ADDR is long long. Index: gdb/solib-spu.c =================================================================== RCS file: /cvs/src/src/gdb/solib-spu.c,v retrieving revision 1.11 diff -u -p -r1.11 solib-spu.c --- gdb/solib-spu.c 25 Jun 2010 17:39:56 -0000 1.11 +++ gdb/solib-spu.c 25 Jun 2010 20:40:57 -0000 @@ -126,8 +126,9 @@ append_ocl_sos (struct so_list **link_pt new = XZALLOC (struct so_list); /* Encode FD and object ID in path name. */ - xsnprintf (new->so_name, sizeof new->so_name, "@0x%lx <%d>", - data, SPUADDR_SPU (*ocl_program_addr_base)); + xsnprintf (new->so_name, sizeof new->so_name, "@%s <%d>", + hex_string (data), + SPUADDR_SPU (*ocl_program_addr_base)); strcpy (new->so_original_name, new->so_name); *link_ptr = new; -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com