From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5236 invoked by alias); 24 Jun 2010 18:23:39 -0000 Received: (qmail 5218 invoked by uid 22791); 24 Jun 2010 18:23:38 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Jun 2010 18:23:34 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5FF5B2BACC6; Thu, 24 Jun 2010 14:23:32 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id IVSkuWPF4Tzh; Thu, 24 Jun 2010 14:23:32 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 205D92BACC4; Thu, 24 Jun 2010 14:23:32 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1293CF5894; Thu, 24 Jun 2010 11:23:17 -0700 (PDT) Date: Thu, 24 Jun 2010 18:23:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org, ktietz70@googlemail.com Subject: Re: [RFA/commit/Win64] Remove new extra leading underscore in symbol name Message-ID: <20100624182317.GI2595@adacore.com> References: <1276813536-31761-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00545.txt.bz2 > Joel> 2010-06-17 Joel Brobecker > Joel> gdb/ > Joel> * coffread.c (getsymname): Skip the leading underscore on pe64. > > I don't know anything about this target, but the binutils patch includes > a --enable-leading-mingw64-underscores option... > > Joel> + const char *target = bfd_get_target (symfile_bfd); > Joel> + const int is_pe64 = (strcmp (target, "pe-x86-64") == 0 > Joel> + || strcmp (target, "pei-x86-64") == 0); > > ...so maybe instead of looking at the target name, it would be better to > use bfd_get_target_info here? I'm a little nervous at changing the check to a non target-specific one without multi-platform testing. Unfortunately, I haven't had a chance to work on this yet, and I'd really like to have that for 7.2. Would it be OK for me to commit this change as is while I instrument what you suggest on all other platforms we have that use COFF? (I'm expecting to be able to make that change today) -- Joel