Re: [patch] Add support for ARMv7M devices.

Doug Evans
2010-06-09T22:29:18Z

On Wed, Jun 9, 2010 at 7:03 AM, Kazu Hirata <kazu@codesourcery.com> wrote:
> Hi,
>
> Attached is a patch to add support for ARMv7M devices.
>
> The patch is bigger than it really is due to the signature change to
> arm_pc_is_thumb.
>
> Here are some highlights:
>
> - arm_pc_is_thumb always returns 1 if the target is an ARMv7M device.
> [...]

No objections for my part, but a nit, and not one that you necessarily
have to address.
Options "arm fallback-mode" and "arm force-mode" are confusing, at
least if you read their help string without digging into the
implementation.
IWBN if the help text specified that they do not apply if the mode can
be discerned from the h/w, and list the ways in which that is done.
In some sense it could be thought of as being obvious (why want
something different from what the h/w says?).
Maybe I'm being excessively pedantic on the use of the word "force".