From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73934-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32295 invoked by alias); 24 Jun 2010 15:10:07 -0000
Received: (qmail 32285 invoked by uid 22791); 24 Jun 2010 15:10:06 -0000
X-SWARE-Spam-Status: No, hits=-5.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Jun 2010 15:09:58 +0000
Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5OF9v2w024711	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Thu, 24 Jun 2010 11:09:57 -0400
Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5OF9spN030466	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);	Thu, 24 Jun 2010 11:09:56 -0400
Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1])	by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o5OF9sGW002532;	Thu, 24 Jun 2010 17:09:54 +0200
Received: (from jkratoch@localhost)	by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o5OF9sx8002531;	Thu, 24 Jun 2010 17:09:54 +0200
Date: Thu, 24 Jun 2010 15:10:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] PR python/11407
Message-ID: <20100624150954.GA2201@host0.dyn.jankratochvil.net>
References: <4C23426F.4020502@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C23426F.4020502@redhat.com>
User-Agent: Mutt/1.5.20 (2009-12-10)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-06/txt/msg00527.txt.bz2

On Thu, 24 Jun 2010 13:33:03 +0200, Phil Muldoon wrote:
>  {
>    struct value *val;
>    struct value_print_options opts;

nitpick: I would prefer move val and opts to the inner TRY_CATCH block now.

[...]
> +  TRY_CATCH (except, RETURN_MASK_ERROR)
> +    {
> +      val = read_var_value (var, frame);
> +      get_user_print_options (&opts);
> +      common_val_print (val, stream, indent, &opts, current_language);
> +    }
> +  if (except.reason < 0)
> +      fprintf_filtered(stream, "<error reading variable %s (%s)>", name,
> +		       except.message);

Wrong indentation/formatting of the fprintf_filtered line.


Thanks,
Jan