Re: [RFC] Add support of software single step to process record

[Pedro Alves <pedro@codesourcery.com>]

Hi Hui,

On Sunday 20 June 2010 08:28:40, Hui Zhu wrote:
> On Fri, Jun 11, 2010 at 21:55, Pedro Alves <pedro@codesourcery.com> wrote:
> > I'm felling a bit dense, and I don't see what is that actually
> > catching.  If going backwards, the assertion always ends up
> > evaled as true, nomatter if sofware single-steps are inserted
> > or not, or whether `step' is set.  Did you mean to assert
> > that when going backwards, there shouldn't ever be software
> > single-step breakpoints inserted?
> >
> > This patch is okay otherwise.  Thanks.
> 
> Thanks Pedro.
> I was also confused by this issue too.  I thought it will never happen
> too.  But Ping said he got this issue.  And I didn't have the risc
> board to test.  So I gived up and put this patch to him.
> 
> So I think this patch is not very hurry to checked in until some one
> post a risc prec support patch.  At that time, I will make this issue
> clear.

I'd be fine with putting the patch in now, but without the change to
that gdb_assert.  It looked like a step in the right direction,
and we can fix any left issues later.

-- 
Pedro Alves