From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29765 invoked by alias); 21 Jun 2010 17:08:02 -0000 Received: (qmail 29597 invoked by uid 22791); 21 Jun 2010 17:08:01 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Jun 2010 17:07:57 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 942702BAC1C; Mon, 21 Jun 2010 13:07:54 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5dOE8IgfDwSd; Mon, 21 Jun 2010 13:07:54 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 40A482BAB66; Mon, 21 Jun 2010 13:07:54 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id AEF35F58FA; Mon, 21 Jun 2010 10:07:43 -0700 (PDT) Date: Mon, 21 Jun 2010 17:08:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: brobecke@sourceware.org, gdb-patches@sourceware.org, 'Pedro Alves' Subject: Re: [RFA] Fix Cygwin problem with banned variables Message-ID: <20100621170743.GD2595@adacore.com> References: <20100517171128.29087.qmail@sourceware.org> <001201cb0f8b$472f8b00$d58ea100$@muller@ics-cnrs.unistra.fr> <003c01cb1089$208e45f0$61aad1d0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <003c01cb1089$208e45f0$61aad1d0$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00458.txt.bz2 > This generates multiple calls to 'trace variable ' and only one call > to 'trace remove variable '. The TCL documentation is not directly explicit about that, but some experimentation shows that this is indeed a problem. And rereading the docuemntation with that in mind, the duplicate traces are probably treated as distinct traces. Thus, when doing only one remove for the trace, we're still left with at least one trace. > 2010-06-19 Pierre Muller > > * lib/gdb.exp (banned_variables_traced): New global variable. > (gdb_init, gdb_finish): Use new variable to avoid multiple > tracing. > (gdb_init): Use `trace add variable ' instead of obsolete > `trace variable '. Just one detail, but otherwise OK. > @@ -2519,6 +2519,7 @@ if ![info exists gdb_test_timeout] { > # We try to prevent their use by monitoring write accesses and raising > # an error when that happens. > set banned_variables { bug_id prms_id } > +set banned_variables_traced 0 Please add a comment explaining what this global is used for and why it is necessary. Thanks, -- Joel