From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16752 invoked by alias); 21 Jun 2010 16:57:34 -0000 Received: (qmail 16733 invoked by uid 22791); 21 Jun 2010 16:57:32 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Jun 2010 16:57:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D05292BAC2D; Mon, 21 Jun 2010 12:57:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 9Ha85lBw420E; Mon, 21 Jun 2010 12:57:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 03C9D2BAC1C; Mon, 21 Jun 2010 12:57:24 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0B7AAF58FA; Mon, 21 Jun 2010 09:57:14 -0700 (PDT) Date: Mon, 21 Jun 2010 16:57:00 -0000 From: Joel Brobecker To: Hui Zhu Cc: Stan Shebs , Tom Tromey , Stan Shebs , Michael Snyder , gdb-patches ml , Eli Zaretskii Subject: Re: [RFC] Let "gcore" command accept a suffix argument Message-ID: <20100621165714.GC2595@adacore.com> References: <20100106075757.GF24777@adacore.com> <20100109105557.GA2007@adacore.com> <20100110054328.GD2007@adacore.com> <20100110140029.GF2007@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00457.txt.bz2 > 2010-06-21 Hui Zhu > > * printcmd.c (ui_printf_maybe_filtered): New function. > (printf_command): Call ui_printf_maybe_filtered. > (_initialize_printcmd): New command "eval". This is close. > static void > -printf_command (char *arg, int from_tty) > +ui_printf_maybe_filtered (char *arg, struct ui_file *stream, int filter) I would personally prefer it if we called this function "ui_printf", dropping the "maybe_filtered". The "maybe_filtered" is just noise, IMO. Also, this function needs a comment documenting its behavior. > +static void > +printf_command (char *arg, int from_tty) Please add a comment as well. It can be as simple as ``Implement the "print" command''. > +static void > +eval_command (char *arg, int from_tty) > +{ And same here. > + add_com ("eval", no_class, eval_command, _("\ > +Call command with variable.")); This part will need to be approved by Eli. He's also ask for documentation. -- Joel