From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4469 invoked by alias); 16 Jun 2010 17:39:20 -0000 Received: (qmail 4445 invoked by uid 22791); 16 Jun 2010 17:39:17 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Jun 2010 17:39:09 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5GHd7th004600 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 16 Jun 2010 13:39:07 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5GHd5GA016812 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 16 Jun 2010 13:39:06 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o5GHd43o011955; Wed, 16 Jun 2010 19:39:04 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o5GHd4aU011954; Wed, 16 Jun 2010 19:39:04 +0200 Date: Wed, 16 Jun 2010 17:39:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [1/7] RFC: minimal BFD thread awareness Message-ID: <20100616173903.GB32701@host0.dyn.jankratochvil.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00366.txt.bz2 Hi Tom, On Mon, 14 Jun 2010 20:22:56 +0200, Tom Tromey wrote: > --- a/bfd/bfd-in2.h > +++ b/bfd/bfd-in2.h > @@ -2572,6 +2572,8 @@ relocation types already defined. */ > + BFD_RELOC_SPU_PIC18, > + BFD_RELOC_SPU_STUB, > --- a/bfd/libbfd.h > +++ b/bfd/libbfd.h > + "BFD_RELOC_SPU_PIC18", > + "BFD_RELOC_SPU_STUB", Isn't this some leftover? > --- a/bfd/bfd-in2.h > +++ b/bfd/bfd-in2.h > @@ -5353,6 +5355,25 @@ bfd_boolean core_file_matches_executable_p > +struct bfd_thread_info > +{ > + /* Return the ID of the current thread. Should never return NULL. */ > + void *(*self) (void); > + /* Create a mutex and return it. */ > + void *(*create_mutex) (void); I would prefer some opaque struct * typedefs so that the mutex vs. thread-id have incompatible types. Thanks, Jan