From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13402 invoked by alias); 11 Jun 2010 23:30:51 -0000 Received: (qmail 13392 invoked by uid 22791); 11 Jun 2010 23:30:50 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.17.163) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Jun 2010 23:30:44 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.1/8.13.1) with ESMTP id o5BNUfsp027300 for ; Fri, 11 Jun 2010 23:30:41 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5BNUfg71286246 for ; Sat, 12 Jun 2010 01:30:41 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o5BNUfAH014810 for ; Sat, 12 Jun 2010 01:30:41 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id o5BNUe2i014801; Sat, 12 Jun 2010 01:30:40 +0200 Message-Id: <201006112330.o5BNUe2i014801@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Sat, 12 Jun 2010 01:30:40 +0200 Subject: Re: [RFA] gdb.trace, replace wildcard regexp To: msnyder@vmware.com (Michael Snyder) Date: Fri, 11 Jun 2010 23:30:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (gdb-patches@sourceware.org), pedro@codesourcery.com (Pedro Alves) In-Reply-To: <4C12BCE7.7010403@vmware.com> from "Michael Snyder" at Jun 11, 2010 03:47:03 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00293.txt.bz2 Michael Snyder wrote: > Yeah, but these ones really do fail, when the target can't do > tracepoints. They need to be run against gdbserver. > > Odd, though, most of the trace tests bail early if the target > can't do tracepoints. They don't give arbitrary failures... Ah, I see. All the other tests check gdb_target_supports_trace; this check is missing in packetlen.exp. The patch below adds the same logic used by the other tests. Tested on spu-elf, committed to mainline. Bye, Ulrich ChangeLog: * gdb.trace/packetlen.exp: Respect gdb_target_supports_trace. Index: gdb/testsuite/gdb.trace/packetlen.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.trace/packetlen.exp,v retrieving revision 1.15 diff -u -p -r1.15 packetlen.exp --- gdb/testsuite/gdb.trace/packetlen.exp 8 Jun 2010 22:58:03 -0000 1.15 +++ gdb/testsuite/gdb.trace/packetlen.exp 11 Jun 2010 23:23:34 -0000 @@ -39,6 +39,14 @@ gdb_test "tfind none" ".*" "" runto_main gdb_reinitialize_dir $srcdir/$subdir +# We generously give ourselves one "pass" if we successfully +# detect that this test cannot be run on this target! +if { ![gdb_target_supports_trace] } then { + pass "Current target does not support trace" + return 1; + +} + # If testing on a remote host, download the source file. # remote_download host $srcdir/$subdir/$srcfile -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com