From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19034 invoked by alias); 8 Jun 2010 17:34:14 -0000 Received: (qmail 19014 invoked by uid 22791); 8 Jun 2010 17:34:12 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Jun 2010 17:34:06 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o58HY4Rx021657 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 8 Jun 2010 13:34:04 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o58HY2QO011336 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 8 Jun 2010 13:34:04 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o58HY2NS002030; Tue, 8 Jun 2010 19:34:02 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o58HY1ZS002026; Tue, 8 Jun 2010 19:34:01 +0200 Date: Tue, 08 Jun 2010 17:34:00 -0000 From: Jan Kratochvil To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [patch] gdb.base/pending.exp replace gdb_test_multi Message-ID: <20100608173400.GA1796@host0.dyn.jankratochvil.net> References: <4C097B4A.8080005@vmware.com> <20100607225102.GA8046@host0.dyn.jankratochvil.net> <4C0D79F3.4070005@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C0D79F3.4070005@vmware.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00211.txt.bz2 On Tue, 08 Jun 2010 01:00:03 +0200, Michael Snyder wrote: > Jan Kratochvil wrote: > >On Sat, 05 Jun 2010 00:16:42 +0200, Michael Snyder wrote: > >>+gdb_test "break pendfunc2" \ > >>+ "" \ > >>+ "Don't set pending breakpoint" \ > >>+ ".*Make breakpoint pending.*y or \\\[n\\\]. $" \ > >>+ "n" > > > >With ".*" vs. gdb_test_no_output distinguishing now should be ".*" here > >instead? (Maybe a more specific string would be also appropriate.) > > No, unfortunately, the expected string here is the empty string; OK, it is a string after the question, not before it, my mistake. > Believe me, it's almost heart-breaking for me to have to leave this, > but I don't see it as worthwhile to extend gdb_test_no_output to > handle the query case. During the gdb_test_no_output introduction there was not the "" -> ".*" change in place. Don't you plan to remove gdb_test_no_output now and put that [string_to_regexp $command] into each gdb_test (gdb_test_multiple)? That would solve even this case. (For testing GDB asks at all there is "pendfunc1" before this test so dropping this part of the test as you did is probably not a problem.) Thanks, Jan