From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7817 invoked by alias); 7 Jun 2010 06:11:54 -0000 Received: (qmail 7802 invoked by uid 22791); 7 Jun 2010 06:11:53 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail.gmx.net (HELO mail.gmx.net) (213.165.64.20) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Mon, 07 Jun 2010 06:11:48 +0000 Received: (qmail invoked by alias); 07 Jun 2010 06:11:45 -0000 Received: from xdsl-89-0-140-112.netcologne.de (EHLO localhost.localdomain) [89.0.140.112] by mail.gmx.net (mp063) with SMTP; 07 Jun 2010 08:11:45 +0200 Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1OLVYn-0007lr-2z; Mon, 07 Jun 2010 08:11:45 +0200 Date: Mon, 07 Jun 2010 06:11:00 -0000 From: Ralf Wildenhues To: Ian Lance Taylor Cc: Paolo Bonzini , binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Fix PR bootstrap/42798 Message-ID: <20100607061142.GA29811@gmx.de> References: <20100601204405.GA1170@gmx.de> <20100602111845.GA16161@ins.uni-bonn.de> <4C064B77.3020207@gnu.org> <20100603063319.GC28276@gmx.de> <20100603065852.GA28617@gmx.de> <20100606112828.GC29478@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-10-28) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00165.txt.bz2 * Ian Lance Taylor wrote on Sun, Jun 06, 2010 at 11:42:13PM CEST: > Ralf Wildenhues writes: > > * Ian Lance Taylor wrote on Fri, Jun 04, 2010 at 04:59:01PM CEST: > >> With regard to the gold change. What will happen if the system header > >> files provide only a declaration > >> char *basename(const char *) > >> ? > >> > >> Since gold doesn't actually basename, another option here would be to > >> skip the check of the basename declaration entirely. In fact, we > >> should consider dropping basename from libiberty; our code should in > >> general use lbasename anyhow. > > > > Well, these are two additional changes on top of the one I posted though > > and can easily be addressed in the future. Meanwhile, a combined build > > with maintainer-mode enabled will cause spurious changes to generated > > files, and the patch is pretty minimal in that it fixes the issues but > > doesn't change semantics otherwise. So, ok to commit to src? > > My question about a basename declaration in the system header was a > genuine question. My concern is that on some systems this patch might > decide incorrectly whether or not basename is defined, which could > then possibly lead to a compilation error when libiberty.h is > included. This concern should be addressed with my reply : In short, the Autoconf change is designed to handle exactly this case right both in C and in C++ mode. > The gold patch is fine if you omit basename entirely from the gold > configure.ac. I don't see how that could cause trouble given the > current libiberty.h. OK, thanks. I still need approval for the (really trivial) bfd and opcodes changes. Cheers, Ralf