From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32346 invoked by alias); 6 Jun 2010 11:28:56 -0000 Received: (qmail 32329 invoked by uid 22791); 6 Jun 2010 11:28:55 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,TW_CX X-Spam-Check-By: sourceware.org Received: from mail.gmx.net (HELO mail.gmx.net) (213.165.64.20) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sun, 06 Jun 2010 11:28:50 +0000 Received: (qmail invoked by alias); 06 Jun 2010 11:28:46 -0000 Received: from xdsl-78-35-59-207.netcologne.de (EHLO localhost.localdomain) [78.35.59.207] by mail.gmx.net (mp044) with SMTP; 06 Jun 2010 13:28:46 +0200 Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1OLE1p-0000Pc-OD; Sun, 06 Jun 2010 13:28:33 +0200 Date: Sun, 06 Jun 2010 11:28:00 -0000 From: Ralf Wildenhues To: Ian Lance Taylor Cc: Paolo Bonzini , binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Fix PR bootstrap/42798 Message-ID: <20100606112828.GC29478@gmx.de> References: <20100601204405.GA1170@gmx.de> <20100602111845.GA16161@ins.uni-bonn.de> <4C064B77.3020207@gnu.org> <20100603063319.GC28276@gmx.de> <20100603065852.GA28617@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-10-28) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00160.txt.bz2 * Ian Lance Taylor wrote on Fri, Jun 04, 2010 at 04:59:01PM CEST: > Ralf Wildenhues writes: > > > This is the followup patch for src. Tested by building binutils+gdb, > > I'm starting a combined tree with --enable-build-with-cxx now. > > Ok to commit if no problems show up? > > > > A note to the gold change: I've looked at git glibc headers, of the > > declarations tested only 'basename' was overloaded. If more are added > > in the future, the configure.ac files need to be adjusted to give > > parameters for them, too. This applies to the whole tree of course for > > --enable-build-with-cxx, not just for gold. > > With regard to the gold change. What will happen if the system header > files provide only a declaration > char *basename(const char *) > ? > > Since gold doesn't actually basename, another option here would be to > skip the check of the basename declaration entirely. In fact, we > should consider dropping basename from libiberty; our code should in > general use lbasename anyhow. Well, these are two additional changes on top of the one I posted though and can easily be addressed in the future. Meanwhile, a combined build with maintainer-mode enabled will cause spurious changes to generated files, and the patch is pretty minimal in that it fixes the issues but doesn't change semantics otherwise. So, ok to commit to src? Thanks, Ralf