From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10625 invoked by alias); 5 Jun 2010 14:38:24 -0000 Received: (qmail 10616 invoked by uid 22791); 5 Jun 2010 14:38:23 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 Jun 2010 14:38:20 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o55EbuEO029951 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 5 Jun 2010 10:37:56 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o55EbraA021684 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 5 Jun 2010 10:37:55 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o55Ebre9016529; Sat, 5 Jun 2010 16:37:53 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o55EbqIY016528; Sat, 5 Jun 2010 16:37:52 +0200 Date: Sat, 05 Jun 2010 14:38:00 -0000 From: Jan Kratochvil To: Sergio Durigan Junior Cc: Joel Brobecker , gdb-patches@sourceware.org, tromey@redhat.com Subject: Re: [PATCH] Forbid watchpoint on a constant value Message-ID: <20100605143752.GA14558@host0.dyn.jankratochvil.net> References: <20100521070500.GA30452@host0.dyn.jankratochvil.net> <201005211912.39680.sergiodj@redhat.com> <20100528231122.GO3019@adacore.com> <201006050150.08687.sergiodj@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201006050150.08687.sergiodj@redhat.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00156.txt.bz2 On Sat, 05 Jun 2010 06:50:08 +0200, Sergio Durigan Junior wrote: > One thing to notice is that instead of doing: > > if (!TYPE_CONST (SYMBOL_TYPE (s)) != TYPE_CODE_FUNC > ... > > I am now doing: > > if (!SYMBOL_CLASS (s) != LOC_BLOCK > ... > > Jan kindly suggested me to do this change, and I checked the DWARF spec in > order to see if LOC_BLOCK is equivalent to TYPE_CODE_FUNC. The DWARF spec http://www.dwarfstd.org/doc/DWARF4-public-review.pdf contains neither LOC_BLOCK nor TYPE_CODE_FUNC. But I have checked now TYPE_CODE_FUNC and LOC_BLOCK are IMO equivalent at least for the DWARF symbols in this case as being read in by dwarf2read.c. Thanks, Jan