From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17863 invoked by alias); 4 Jun 2010 14:31:28 -0000 Received: (qmail 17840 invoked by uid 22791); 4 Jun 2010 14:31:24 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Jun 2010 14:31:15 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o54EUpTl010943 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Jun 2010 10:30:51 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o54EUmkA027880 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Jun 2010 10:30:50 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o54EUmiJ014845; Fri, 4 Jun 2010 16:30:48 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o54EUlFN014844; Fri, 4 Jun 2010 16:30:47 +0200 Date: Fri, 04 Jun 2010 14:31:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [patch] testsuite: Error on trailing newlines Message-ID: <20100604143047.GA14395@host0.dyn.jankratochvil.net> References: <20100602214003.GA31569@host0.dyn.jankratochvil.net> <20100602214350.GC3019@adacore.com> <20100602223124.GA2335@host0.dyn.jankratochvil.net> <20100602230235.GH3019@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100602230235.GH3019@adacore.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00116.txt.bz2 On Thu, 03 Jun 2010 01:02:35 +0200, Joel Brobecker wrote: > > * gdb.base/commands.exp (add printf tbreak command): Remove trailing > > newline. > > * gdb.gdb/complaints.exp (empty non-verbose non-noisy clear) > > (empty verbose non-noisy clear, empty verbose noisy clear) > > (empty non-verbose noisy clear): Likewise. > > This part is definitely OK (you've treated them as obvious so far). > So let's commit them now. True, checked-in. > Invalid trailing newline in \"$message\" test > > ? I don't mind the gdb_test_multiple in the error message if you think > it makes a difference, but I can see how it can confuse people who are > not familiar with the testsuite infrastructure if the test was written > using gdb_test... I do not mind that message change, thanks. Regards, Jan http://sourceware.org/ml/gdb-cvs/2010-06/msg00040.html --- src/gdb/testsuite/ChangeLog 2010/06/03 23:54:17 1.2313 +++ src/gdb/testsuite/ChangeLog 2010/06/04 14:26:47 1.2314 @@ -1,3 +1,11 @@ +2010-06-04 Jan Kratochvil + + * gdb.base/commands.exp (add printf tbreak command): Remove trailing + newline. + * gdb.gdb/complaints.exp (empty non-verbose non-noisy clear) + (empty verbose non-noisy clear, empty verbose noisy clear) + (empty non-verbose noisy clear): Likewise. + 2010-06-03 Michael Snyder * gdb.base/commands.exp: Replace gdb_test with gdb_test_no_output. --- src/gdb/testsuite/gdb.base/commands.exp 2010/06/03 23:54:17 1.38 +++ src/gdb/testsuite/gdb.base/commands.exp 2010/06/04 14:26:49 1.39 @@ -503,7 +503,7 @@ pass "add silent tbreak command" } } - gdb_test_multiple "printf \"factorial tbreak commands executed\\n\"\n" \ + gdb_test_multiple "printf \"factorial tbreak commands executed\\n\"" \ "add printf tbreak command" { -re ">$" { pass "add printf tbreak command" --- src/gdb/testsuite/gdb.gdb/complaints.exp 2010/05/26 18:31:25 1.13 +++ src/gdb/testsuite/gdb.gdb/complaints.exp 2010/06/04 14:26:52 1.14 @@ -207,13 +207,13 @@ proc test_empty_complaints { } { - test_empty_complaint "call clear_complaints(&symfile_complaints,0,0)\n" \ + test_empty_complaint "call clear_complaints(&symfile_complaints,0,0)" \ "empty non-verbose non-noisy clear" - test_empty_complaint "call clear_complaints(&symfile_complaints,1,0)\n" \ + test_empty_complaint "call clear_complaints(&symfile_complaints,1,0)" \ "empty verbose non-noisy clear" - test_empty_complaint "call clear_complaints(&symfile_complaints,1,1)\n" \ + test_empty_complaint "call clear_complaints(&symfile_complaints,1,1)" \ "empty verbose noisy clear" - test_empty_complaint "call clear_complaints(&symfile_complaints,0,1)\n" \ + test_empty_complaint "call clear_complaints(&symfile_complaints,0,1)" \ "empty non-verbose noisy clear" return 0