From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29777 invoked by alias); 2 Jun 2010 22:06:35 -0000 Received: (qmail 29670 invoked by uid 22791); 2 Jun 2010 22:06:33 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Jun 2010 22:06:29 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 699942BAC88; Wed, 2 Jun 2010 18:06:27 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id PBVR0OvncGO9; Wed, 2 Jun 2010 18:06:27 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 37F6A2BAC24; Wed, 2 Jun 2010 18:06:27 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8A58FF58FA; Wed, 2 Jun 2010 15:06:22 -0700 (PDT) Date: Wed, 02 Jun 2010 22:06:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Extend Fortran detection filename extensions Message-ID: <20100602220622.GD3019@adacore.com> References: <20100602214059.GB30562@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100602214059.GB30562@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00077.txt.bz2 > gdb/ > 2010-06-02 Jan Kratochvil > > * symfile.c (init_filename_language_table): New extensions .for, .FOR, > .ftn, .FTN, .fpp, .FPP, .f90, .F90, .f95, .F95, .f03, .F03, .f08 and > .F08. This seems reasonable to me. I wish I knew more languages that I do now, but I don't see some of these extensions being used by other languages as well. So this seems OK to me (and would be easy to adjust if someone else has more info about a possible collision). > gdb/testsuite/ > 2010-06-02 Jan Kratochvil > > * gdb.fortran/module.exp (stopped language detection): New test. A question about this new test (which is OK, btw). > +# Test automatic language detection before the inferior starts. > +gdb_test "p modmany::var_i" " = 14" "stopped language detection" Why not just do "show language"? -- Joel