From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8758 invoked by alias); 2 Jun 2010 16:30:38 -0000 Received: (qmail 8744 invoked by uid 22791); 2 Jun 2010 16:30:37 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Jun 2010 16:30:31 +0000 Received: (qmail 3609 invoked from network); 2 Jun 2010 16:30:29 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 2 Jun 2010 16:30:29 -0000 From: Pedro Alves To: Jan Kratochvil Subject: Re: [patch] new testcase: Internal error on unqualified name re-set (PR 11657) Date: Wed, 02 Jun 2010 16:30:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.32-22-generic; KDE/4.4.2; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <20100602143233.GA22447@host0.dyn.jankratochvil.net> <201006021603.50479.pedro@codesourcery.com> <20100602161218.GA31980@host0.dyn.jankratochvil.net> In-Reply-To: <20100602161218.GA31980@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201006021730.19408.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00045.txt.bz2 On Wednesday 02 June 2010 17:12:18, Jan Kratochvil wrote: > On Wed, 02 Jun 2010 17:03:50 +0200, Pedro Alves wrote: > > On Wednesday 02 June 2010 15:32:33, Jan Kratochvil wrote: > > > > > +# Create and source the file that provides information about the compiler > > > +# used to compile the test case. > > > +if [get_compiler_info ${binfile} "c++"] { > > > + return -1 > > > +} > > > > Is this bit actually needed in this test? > > Yes. > > lib/gdb.exp: > # Build a shared library from SOURCES. You must use get_compiler_info > # first. > proc gdb_compile_shlib {sources dest options} { > Ah. Always learning. > > > > +clean_restart $executable > > > +gdb_load_shlibs ${sofile} > > > + > > > +gdb_test_no_output "set breakpoint pending yes" > > > +gdb_test "break C::C" {Breakpoint [0-9]+ \(C::C\) pending\.} "break C::C" > > > +gdb_test_no_output {set variable $brk = $bpnum} > > > + > > > +gdb_breakpoint "main" > > > +gdb_run_cmd > > > +gdb_test "" "" "start" > > > > Doesn't runto_main work in this case? > > No. Added: > # runto or runto_main would call delete_breakpoints. Thanks. > > > > So will the test hit an internal error, causing a new FAIL? > > How about setting up a kfail with the PR number? > > Forgot, KFAILed now: > Running ./gdb.cp/re-set-overloaded.exp ... > PASS: gdb.cp/re-set-overloaded.exp: set breakpoint pending yes > PASS: gdb.cp/re-set-overloaded.exp: break C::C > PASS: gdb.cp/re-set-overloaded.exp: set variable $brk = $bpnum > KFAIL: gdb.cp/re-set-overloaded.exp: start (GDB internal error) (PRMS: breakpoints/11657) > KFAIL: gdb.cp/re-set-overloaded.exp: breakpoint resolved (PRMS: breakpoints/11657) > > OK to check-in? Great, thanks. This is fine with me. > > > Thanks, > Jan > > > gdb/testsuite/ > 2010-06-02 Jan Kratochvil > > * gdb.cp/re-set-overloaded.exp, gdb.cp/re-set-overloaded.cc: New. > > --- /dev/null > +++ b/gdb/testsuite/gdb.cp/re-set-overloaded.cc > @@ -0,0 +1,26 @@ > +/* This testcase is part of GDB, the GNU debugger. > + > + Copyright 2010 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +class C > + { > + public: > + C() {} > + C(int x) {} > + }; > + > +C a; > +C b(1); > --- /dev/null > +++ b/gdb/testsuite/gdb.cp/re-set-overloaded.exp > @@ -0,0 +1,61 @@ > +# Copyright 2010 Free Software Foundation, Inc. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +if { [skip_cplus_tests] } { continue } > +if { [skip_shlib_tests] } { continue } > + > +set testfile re-set-overloaded > +set srcfile bool.cc > +set executable $testfile > +set binfile $objdir/$subdir/$executable > + > +set libsrcfile ${testfile}.cc > +set sofile $objdir/$subdir/${testfile}.so > + > +# Create and source the file that provides information about the compiler > +# used to compile the test case. > +if [get_compiler_info ${binfile} "c++"] { > + return -1 > +} > + > +if { [gdb_compile_shlib $srcdir/$subdir/$libsrcfile $sofile {debug c++}] != "" > + || [gdb_compile $srcdir/$subdir/$srcfile $binfile executable [list debug "c++" shlib=${sofile}]] != ""} { > + untested ${testfile}.exp > + return -1 > +} > + > +clean_restart $executable > +gdb_load_shlibs ${sofile} > + > +gdb_test_no_output "set breakpoint pending yes" > +gdb_test "break C::C" {Breakpoint [0-9]+ \(C::C\) pending\.} "break C::C" > +gdb_test_no_output {set variable $brk = $bpnum} > + > +# runto or runto_main would call delete_breakpoints. > +gdb_breakpoint "main" > +gdb_run_cmd > +setup_kfail breakpoints/11657 *-*-* > +gdb_test "" "" "start" > + > +set test "breakpoint resolved" > +gdb_test_multiple {info breakpoints $brk} $test { > + -re "" { > + kfail breakpoints/11657 $test > + } > + -re "\r\n$gdb_prompt $" { > + # FIXME: Check more specific resolution state. > + pass $test > + } > +} > -- Pedro Alves