From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73441-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3664 invoked by alias); 1 Jun 2010 22:49:07 -0000
Received: (qmail 3458 invoked by uid 22791); 1 Jun 2010 22:49:06 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Jun 2010 22:48:56 +0000
Received: (qmail 9467 invoked from network); 1 Jun 2010 22:48:54 -0000
Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 1 Jun 2010 22:48:54 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] gdb.threads/*.exp: send_gdb vs. gdb_test
Date: Tue, 01 Jun 2010 22:49:00 -0000
User-Agent: KMail/1.13.2 (Linux/2.6.32-22-generic; KDE/4.4.2; x86_64; ; )
Cc: Michael Snyder <msnyder@vmware.com>, Joel Brobecker <brobecker@adacore.com>
References: <4BFDBBFB.8030503@vmware.com> <20100601214837.GS3019@adacore.com> <4C058858.1070707@vmware.com>
In-Reply-To: <4C058858.1070707@vmware.com>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201006012348.51797.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-06/txt/msg00034.txt.bz2

On Tuesday 01 June 2010 23:23:20, Michael Snyder wrote:
> >> -    send_gdb "continue\n"
> >> -    gdb_expect {
> >> -    -re "Continuing.*common_routine.*at.*$srcfile.*$gdb_prompt $" {}
> >> +    gdb_test_multiple "continue" "continue until common routine run 15 times" {
> >> +    -re "Continuing.*common_routine.*at.*$srcfile.*$gdb_prompt $" {
> >> +    }
> >>      default {
> >>          fail "continue until common routine run 15 times"
> >>          return 0
> > 
> > Shouldn't we delete the "default" & "timeout" sections in this case?
> 
> I left them in because they do a "return", which wouldn't happen
> if they were removed.

Then, as I explained in other reviews, you should really move the
return statement outside of gdb_test_multiple, because as is, the
"fail"s caught by gdb_test_multiple's internals won't cause a return.

-- 
Pedro Alves