From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73435-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19991 invoked by alias); 1 Jun 2010 21:48:52 -0000
Received: (qmail 19983 invoked by uid 22791); 1 Jun 2010 21:48:52 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Jun 2010 21:48:42 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 77A332BAC22;	Tue,  1 Jun 2010 17:48:40 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id a3GdStUwvtqZ; Tue,  1 Jun 2010 17:48:40 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id 2A55F2BAC19;	Tue,  1 Jun 2010 17:48:40 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000)	id 1DFA0F58FA; Tue,  1 Jun 2010 14:48:37 -0700 (PDT)
Date: Tue, 01 Jun 2010 21:48:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdb.threads/*.exp: send_gdb vs. gdb_test
Message-ID: <20100601214837.GS3019@adacore.com>
References: <4BFDBBFB.8030503@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BFDBBFB.8030503@vmware.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-06/txt/msg00028.txt.bz2

> 2010-05-26  Michael Snyder  <msnyder@msnyder-server.eng.vmware.com>
> 
> 	* gdb.threads/attach-stopped.exp: Replace send_gdb with gdb_test.
> 	* gdb.threads/attachstop-mt.exp: Replace send_gdb with gdb_test.
> 	* gdb.threads/gcore-thread.exp: Replace send_gdb with gdb_test.
> 	* gdb.threads/hand-call-in-threads.exp: Replace send_gdb with gdb_test.
> 	* gdb.threads/linux-dp.exp: Replace send_gdb with gdb_test.
> 	* gdb.threads/print-threads.exp: Replace send_gdb with gdb_test.
> 	* gdb.threads/pthreads.exp: Replace send_gdb with gdb_test.
> 	* gdb.threads/schedlock.exp: Replace send_gdb with gdb_test.
> 	* gdb.threads/sigthread.exp: Replace send_gdb with gdb_test.

Looks fine to me. Just one observation...


> Index: pthreads.exp
[...]
> -    send_gdb "continue\n"
> -    gdb_expect {
> -	-re "Continuing.*common_routine.*at.*$srcfile.*$gdb_prompt $" {}
> +    gdb_test_multiple "continue" "continue until common routine run 15 times" {
> +	-re "Continuing.*common_routine.*at.*$srcfile.*$gdb_prompt $" {
> +	}
>  	default {
>  	    fail "continue until common routine run 15 times"
>  	    return 0

Shouldn't we delete the "default" & "timeout" sections in this case?

-- 
Joel