From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6983 invoked by alias); 27 May 2010 15:17:38 -0000 Received: (qmail 6974 invoked by uid 22791); 27 May 2010 15:17:36 -0000 X-Spam-Check-By: sourceware.org Received: from pool-173-76-55-5.bstnma.fios.verizon.net (HELO cgf.cx) (173.76.55.5) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Thu, 27 May 2010 15:17:32 +0000 Received: from ednor.cgf.cx (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id B347413C061; Thu, 27 May 2010 11:17:30 -0400 (EDT) Received: by ednor.cgf.cx (Postfix, from userid 201) id AD25E2B352; Thu, 27 May 2010 11:17:30 -0400 (EDT) Date: Thu, 27 May 2010 15:43:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org, Pierre Muller Subject: Re: [RFA] windows-nat.c: Copy console information for new console Message-ID: <20100527151730.GA483@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org, Pierre Muller References: <001901caf934$fd580460$f8080d20$@muller@ics-cnrs.unistra.fr> <20100525205241.GA5298@ednor.casa.cgf.cx> <000601cafca7$ead3af80$c07b0e80$@muller@ics-cnrs.unistra.fr> <20100526170712.GA32594@ednor.casa.cgf.cx> <001801cafd69$018b9a00$04a2ce00$@muller@ics-cnrs.unistra.fr> <001e01cafd6c$2a0c87c0$7e259740$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <001e01cafd6c$2a0c87c0$7e259740$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00636.txt.bz2 On Thu, May 27, 2010 at 09:13:53AM +0200, Pierre Muller wrote: > Please disregard the patch in the previous email, >it contains an error that generates a compilation failure, >sorry about this. > >> From Christopher Faylor >> I actually thought fairly carefully about flags. If you have a >> function >> which controls console info, then the function should set the flags >> appropriately to deal with the console info. > > > As you prefer, >here is a new version that also takes DWORD *flags as parameter. > I also tried to explain a little bit better >what the function tries to do. Thanks. Looks good. I forgot to say: Thanks for doing this. It looks like a nice improvement. cgf