From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10819 invoked by alias); 26 May 2010 04:44:26 -0000 Received: (qmail 10809 invoked by uid 22791); 26 May 2010 04:44:25 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 May 2010 04:44:21 +0000 Received: (qmail 24442 invoked from network); 26 May 2010 04:44:19 -0000 Received: from unknown (HELO wind.localnet) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 May 2010 04:44:19 -0000 From: Vladimir Prus To: Michael Snyder Subject: Re: [RFA] gdb.mi/*.exp, send_gdb vs. gdb_test Date: Wed, 26 May 2010 07:49:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-21-generic-pae; KDE/4.3.2; i686; ; ) Cc: "gdb-patches@sourceware.org" References: <4BFC6CF2.1090103@vmware.com> In-Reply-To: <4BFC6CF2.1090103@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201005260844.17679.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00590.txt.bz2 On Wednesday 26 May 2010 04:36:02 Michael Snyder wrote: > - send_gdb "-gdb-version\n" > - gdb_expect { > - -re "GNU gdb .*\r\n$mi_gdb_prompt$" \ > - { pass "acceptance of MI operations" > - return 1} > - -re ".*\r\n$mi_gdb_prompt$" \ > - { fail "acceptance of MI operations" > - note "Skipping all other MI tests." } > - -re "Undefined command.*$gdb_prompt $" \ > - { fail "acceptance of MI operations" > - note "Skipping all other MI tests." } > - -re ".*$gdb_prompt $" \ > - { fail "acceptance of MI operations" > - note "Skipping all other MI tests." } > - timeout { fail "acceptance of MI operations (timeout)" > - note "Skipping all other MI tests." } > + gdb_test_multiple "-gdb-version" "acceptance of MI operations" { You replace send_gdb with gdb_test_multiple, while changelog say you replace with gdb_test. > + note "Skipping all other MI tests." This seem to be emitted unconditionally now? It was previously emitted on timeout only. There are two such issues in -- mi-basics and mi2-basics. Seems OK otherwise. - Volodya Thanks, -- Vladimir Prus CodeSourcery vladimir@codesourcery.com (650) 331-3385 x722