From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13024 invoked by alias); 20 May 2010 21:47:03 -0000 Received: (qmail 13017 invoked by uid 22791); 20 May 2010 21:47:02 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 May 2010 21:46:52 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id EECC02BB2CB; Thu, 20 May 2010 17:46:50 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id wXmuqeNKV2hr; Thu, 20 May 2010 17:46:50 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 07FDA2BB2C9; Thu, 20 May 2010 17:46:49 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8C02CF58FA; Thu, 20 May 2010 14:46:47 -0700 (PDT) Date: Thu, 20 May 2010 21:49:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Add gdb_libdir/python- in front of Python search path. Message-ID: <20100520214647.GG3019@adacore.com> References: <1274380803-25266-1-git-send-email-brobecker@adacore.com> <1274380803-25266-3-git-send-email-brobecker@adacore.com> <20100520212805.GA8617@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100520212805.GA8617@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00454.txt.bz2 On Thu, May 20, 2010 at 11:28:05PM +0200, Jan Kratochvil wrote: > On Thu, 20 May 2010 20:40:03 +0200, Joel Brobecker wrote: > > +\n\ > > +# Put gdb_libdir/python- in the python search path. This allows\n\ > > +# us to provide GDB bundled with its own python runtime (the .py/pyc files).\n\ > > +sys.path.insert(0, gdb.libdir + \"/python-%d.%d\" % (sys.version_info[0],\n\ > > + sys.version_info[1]))\n\ > > While I do not mind wrt FSF GDB I find this kind of patch as the schoolbook > example of a distro patch nobody expects to be accepted upstream. I have to disagree about that ("textbook example" is a little harsh, no?) - I wouldn't have proposed this idea if I didn't think that it wouldn't be useful to others. I guess we have to take one step back and decide whether we want to help users who build binaries like AdaCore does, or not. I don't think that this is the first time that someone introduces a patch that helps in that direction, and I don't think we're doing a disservice to GDB to adding it either. It's not like it's a complicated and intrusive change... I'm going to hold off on that for a day or two, see what everyone thinks. If it has to be kept inside AdaCore, then so be it. But it's clear, just with Dan's answer, that someone else would benefit from the code. And code sharing means more time to work on other stuff. > I could push the same way patch for using gcc44 for specific testcases > requiring newer gcc, workaround of Red Hat specific kernel incompatibility or > workaround of upstream ccache bug which you voted for not including in FSF GDB > http://sourceware.org/ml/gdb-patches/2009-03/msg00026.html We can revisit the decision. I don't remember the details, but I feel that the situation was not the same then. -- Joel