From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18015 invoked by alias); 14 May 2010 20:14:22 -0000 Received: (qmail 18007 invoked by uid 22791); 14 May 2010 20:14:21 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 May 2010 20:14:14 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4EKE9V3030279 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 14 May 2010 16:14:09 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o4EKE7CJ031115 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 14 May 2010 16:14:08 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o4EKE6Xh030537; Fri, 14 May 2010 22:14:06 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o4EKE5UR030536; Fri, 14 May 2010 22:14:05 +0200 Date: Fri, 14 May 2010 20:19:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFC: fix bug in pieced value with offset Message-ID: <20100514201405.GA30274@host0.dyn.jankratochvil.net> References: <20100514110537.GA25586@host0.dyn.jankratochvil.net> <20100514192324.GA25176@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00311.txt.bz2 On Fri, 14 May 2010 21:54:43 +0200, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil writes: > > Jan> On Fri, 14 May 2010 19:29:33 +0200, Tom Tromey wrote: > >> >>>>> "Jan" == Jan Kratochvil writes: > Jan> Thinking now if the BFD_ENDIAN_BIG patch by Ulrich Weigand > Jan> [rfc] Handle DWARF-2 value pieces residing in *parts* of a register > Jan> http://sourceware.org/ml/gdb-patches/2009-12/msg00305.html > Jan> should not have been applied also for DWARF_VALUE_STACK; but this > Jan> is outside of the scope of this patch. > [...] > Jan> I am sorry, s/should not have/should have/. Does it make sense now? > > Yeah. However I think this is adequately handled by store_unsigned_integer. > Is it not? Yes, you are right. OK, the current FSF GDB HEAD code is right. > Jan> I agree with your sentence. I do not agree your sentence describes > Jan> your code. The comparison present in code is exactly the opposite > Jan> one. Your sentence describes "n < c->addr_size". [...] > Issuing a complaint in this code is somewhat strange. We don't have > information about where the piece originated. I think it would be > better to issue complaints in execute_stack_op... That's true. And read_pieced_value could contain only gdb_assert. Thanks, Jan