From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30027 invoked by alias); 11 May 2010 07:46:41 -0000 Received: (qmail 30017 invoked by uid 22791); 11 May 2010 07:46:41 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 May 2010 07:46:32 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 675622BABF5; Tue, 11 May 2010 03:46:30 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id V5sju5E-Qf92; Tue, 11 May 2010 03:46:30 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 304012BABF4; Tue, 11 May 2010 03:46:29 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2736AF58F9; Tue, 11 May 2010 00:46:28 -0700 (PDT) Date: Tue, 11 May 2010 07:46:00 -0000 From: Joel Brobecker To: Stan Shebs Cc: gdb-patches@sourceware.org Subject: Re: RFC: new struct breakpoint component cond_language... Message-ID: <20100511074628.GF7479@adacore.com> References: <20100510215421.GJ2957@adacore.com> <4BE895C2.6090706@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BE895C2.6090706@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00242.txt.bz2 > Tracepoints add an extra wrinkle to this concept - when connecting > to a target that is currently running a trace, tracepoint conditions > can be uploaded from the target, and in their original source form, > and so have to be reparsed. So to make this work in the > multi-language case, it seems like the tracepoint download should > include the language somehow. I am not very familiar with tracepoints, but I think I see what is happening (disconnecting GDB from the target?). It seems to me that, indeed, tracepoints need to download and upload the condition language as well. In particular: > But then I wonder - when uploading a tracepoint, we receive both the > computed address and the source form of that address, so in theory > we can always deduce the correct language by working back from the > tracepoint address. I do not think so; At the time when the user declares the tracepoint condition, I am assuming that we check the language mode, and that if it is not auto, then we use the current_language as the condition language, regardless of the language of the source. As a result, the condition language cannot be determined from the tracepoint address. -- Joel