From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72924-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19071 invoked by alias); 8 May 2010 21:12:11 -0000
Received: (qmail 19058 invoked by uid 22791); 8 May 2010 21:12:11 -0000
X-SWARE-Spam-Status: No, hits=-5.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 08 May 2010 21:12:03 +0000
Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o48LC1gu012489	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Sat, 8 May 2010 17:12:01 -0400
Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o48LBwX3028080	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)	for <gdb-patches@sourceware.org>; Sat, 8 May 2010 17:12:00 -0400
Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1])	by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o48LBv0Z012398;	Sat, 8 May 2010 23:11:57 +0200
Received: (from jkratoch@localhost)	by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o48LBt0c012391;	Sat, 8 May 2010 23:11:55 +0200
Date: Sat, 08 May 2010 21:12:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] serial, mdebugread, top.c, utils, frame.c: remove unused variables
Message-ID: <20100508211155.GA12079@host0.dyn.jankratochvil.net>
References: <4BE363CE.2000807@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BE363CE.2000807@vmware.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00217.txt.bz2

On Fri, 07 May 2010 02:50:22 +0200, Michael Snyder wrote:
>  static void
>  do_fclose_cleanup (void *arg)
>  {
> -  FILE *file = arg;
>    fclose (arg);
>  }

I believe the intentional was rather `fclose (file);' according to the general
GDB template of callback functions:

void
func (void *arg)
{
  real_type *var = arg;
  
  Use VAR having it type-checked callee prototypes or real_type changes.
}

But I understand it is a nitpick for never-changing FILE * and fclose.


Regards,
Jan