From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27238 invoked by alias); 7 May 2010 16:26:10 -0000 Received: (qmail 27220 invoked by uid 22791); 7 May 2010 16:26:07 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 May 2010 16:26:03 +0000 Received: (qmail 15750 invoked from network); 7 May 2010 16:26:01 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 7 May 2010 16:26:01 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch 3/3] bpstat_what removal Date: Fri, 07 May 2010 16:26:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; ) Cc: Jan Kratochvil , Stan Shebs References: <20100503200217.GD30386@host0.dyn.jankratochvil.net> <4BE02AB0.6060609@codesourcery.com> <20100507161648.GB14342@host0.dyn.jankratochvil.net> In-Reply-To: <20100507161648.GB14342@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201005071725.54236.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00180.txt.bz2 On Friday 07 May 2010 17:16:48, Jan Kratochvil wrote: > This way from existing 24 bp_* breakpoint types you create new artificial > 9 BPSTAT_* types with associated 3 STOP_* types, therefore effectively you > create new artificial 11 BPSTAT/STOP_* breakpoint events. The abstraction is a bit broken currently. Most prominantely, all the 'enum bpstat_what_main_action's should be mutually exclusive with each other; at least BPSTAT_WHAT_CHECK_SHLIBS and BPSTAT_WHAT_CHECK_JIT should _not_ be a bpstat_what. Checking for internal events is independent of whether to stop or not (noisily or not), and to single-step over a breakpoint or not, which is what mostly infrun cares about. -- Pedro Alves