From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] pascal support sizeof (expression)
Date: Fri, 07 May 2010 16:11:00 -0000 [thread overview]
Message-ID: <20100507161035.GA2768@adacore.com> (raw)
In-Reply-To: <004c01caedfa$50bef820$f23ce860$@muller@ics-cnrs.unistra.fr>
> Once more, I ask before committing because I am
> unsure about the ChangeLog entry:
When unsure, I tend to look at prior art ;-).
> Pierre Muller
> Pascal language support maintainer for GDB
>
> 2010-05-07 Pierre Muller <muller@ics.u-strasbg.fr>
>
> * p-exp.y (pascal_parse): Add support for `sizeof (expression)'.
I usually tend to provide the name of the rule, like in makefiles...
Or looking at Tom's entry:
(exp : VARIABLE): Call write_dollar_variable.
> Index: src/gdb/p-exp.y
> ===================================================================
> RCS file: /cvs/src/src/gdb/p-exp.y,v
> retrieving revision 1.49
> diff -u -p -r1.49 p-exp.y
> --- src/gdb/p-exp.y 6 May 2010 00:08:44 -0000 1.49
> +++ src/gdb/p-exp.y 6 May 2010 23:06:14 -0000
> @@ -525,6 +525,9 @@ exp : SIZEOF '(' type ')' %prec UNARY
> write_exp_elt_opcode (OP_LONG); }
> ;
>
> +exp : SIZEOF '(' exp ')' %prec UNARY
> + { write_exp_elt_opcode (UNOP_SIZEOF); }
> +
> exp : STRING
> { /* C strings are converted into array constants
> with
> an explicit null byte added at the end. Thus
--
Joel
next prev parent reply other threads:[~2010-05-07 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 15:31 Pierre Muller
2010-05-07 16:11 ` Joel Brobecker [this message]
2010-05-08 9:20 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100507161035.GA2768@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox