From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22548 invoked by alias); 7 May 2010 14:31:24 -0000 Received: (qmail 22536 invoked by uid 22791); 7 May 2010 14:31:23 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 May 2010 14:31:19 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o47EVAZl001324 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 May 2010 10:31:10 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o47EV4lm022588 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 7 May 2010 10:31:06 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o47EV3Sl014834; Fri, 7 May 2010 16:31:03 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o47EV3U1014833; Fri, 7 May 2010 16:31:03 +0200 Date: Fri, 07 May 2010 14:31:00 -0000 From: Jan Kratochvil To: Mark Kettenis Cc: pedro@codesourcery.com, gdb-patches@sourceware.org Subject: Re: [patch 1/3] Make obconcat use stdarg Message-ID: <20100507143102.GA14342@host0.dyn.jankratochvil.net> References: <20100430181605.GA19190@host0.dyn.jankratochvil.net> <20100502075217.GA29039@host0.dyn.jankratochvil.net> <201005032019.o43KJ55C028671@glazunov.sibelius.xs4all.nl> <201005032200.14472.pedro@codesourcery.com> <201005042101.o44L1XWx030930@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201005042101.o44L1XWx030930@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00170.txt.bz2 On Tue, 04 May 2010 23:01:33 +0200, Mark Kettenis wrote: > > On Monday 03 May 2010 21:19:05, Mark Kettenis wrote: > > > 2010-05-03 Mark Kettenis > > > > > > * remote.c (register_remote_support_xml) > > > (remote_query_supported_append, remote_query_supported): Add cast > > > to NULL used as sentinel. > > > * tracepoint.c (tvariables_info_1): Likewise. > > > * utils.c (add_internal_problem_command): Likewise. [...] > I added the missing spaces and committed the diff. Thanks! Assuming this remaining one is OK to check-in. Regards, Jan gdb/ 2010-05-07 Jan Kratochvil * fbsd-nat.c (fbsd_make_corefile_notes): Add cast to NULL used as sentinel. --- a/gdb/fbsd-nat.c +++ b/gdb/fbsd-nat.c @@ -208,7 +208,8 @@ fbsd_make_corefile_notes (bfd *obfd, int *note_size) char *psargs = xstrdup (fname); if (get_inferior_args ()) - psargs = reconcat (psargs, psargs, " ", get_inferior_args (), NULL); + psargs = reconcat (psargs, psargs, " ", get_inferior_args (), + (char *) NULL); note_data = elfcore_write_prpsinfo (obfd, note_data, note_size, fname, psargs);