From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20282 invoked by alias); 7 May 2010 03:17:07 -0000 Received: (qmail 20262 invoked by uid 22791); 7 May 2010 03:17:04 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,TW_BJ X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 May 2010 03:16:59 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1D6632BAB8C; Thu, 6 May 2010 23:16:58 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id fQ9lLSvOIocV; Thu, 6 May 2010 23:16:58 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BEA882BAB88; Thu, 6 May 2010 23:16:57 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9C877F58F9; Thu, 6 May 2010 20:16:44 -0700 (PDT) Date: Fri, 07 May 2010 03:17:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [patch] ada-lang, c-lang, f-lang, objc-lang, jv-lang, m2-lang, ada-tasks.c: delete unused variables Message-ID: <20100507031644.GZ2768@adacore.com> References: <4BE35310.9020704@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BE35310.9020704@vmware.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00166.txt.bz2 > --- jv-lang.c 22 Apr 2010 23:15:41 -0000 1.83 > +++ jv-lang.c 6 May 2010 23:35:37 -0000 > @@ -268,8 +268,10 @@ type_from_class (struct gdbarch *gdbarch > struct value *utf8_name; > char *nptr; > CORE_ADDR addr; > +#if 0 > struct block *bl; > struct dict_iterator iter; > +#endif Can you explain why using #if 0 instead of deleting these variables? -- Joel