From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: pedro@codesourcery.com
Cc: gdb-patches@sourceware.org, dje@google.com
Subject: Re: Move amd64_insn_length to common code
Date: Thu, 06 May 2010 06:29:00 -0000 [thread overview]
Message-ID: <201005060628.o466S29s016457@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <201005060123.29521.pedro@codesourcery.com> (message from Pedro Alves on Thu, 6 May 2010 01:23:29 +0100)
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Thu, 6 May 2010 01:23:29 +0100
>
> On Friday 30 April 2010 19:54:22, Pedro Alves wrote:
> > I'll be posting a patch that adds code to i386-tdep.c
> > that will need to know the length of an instruction. We already
> > have code for that in amd64-tdep.c. I don't suppose you
> > see a problem with moving it to a more common/reusable place?
>
> FYI, I went ahead and applied this. Easy to revert and address
> some other way if need be.
Looked very reasonable to me anyway.
> > 2010-04-30 Pedro Alves <pedro@codesourcery.com>
> >
> > gdb/
> > * amd64-tdep.c: Include disasm.h.
> > (amd64_insn_length_fprintf, amd64_insn_length_init_dis)
> > (amd64_insn_length): Moved to disasm.c and renamed.
> > (fixup_riprel): Adjust.
> > * disasm.c (do_ui_file_delete): New.
> > (gdb_insn_length): New.
> > (gdb_buffered_insn_length_fprintf)
> > (gdb_buffered_insn_length_init_dis)
> > (gdb_buffered_insn_length): New, moved from amd64-tdep.c, and
> > renamed.
> > * disasm.h (gdb_insn_length): Declare.
> > (gdb_buffered_insn_length): Declare.
prev parent reply other threads:[~2010-05-06 6:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 18:54 Pedro Alves
2010-05-06 0:23 ` Pedro Alves
2010-05-06 6:29 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005060628.o466S29s016457@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox