From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72816-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6770 invoked by alias); 5 May 2010 18:34:51 -0000
Received: (qmail 6761 invoked by uid 22791); 5 May 2010 18:34:50 -0000
X-SWARE-Spam-Status: No, hits=-2.2 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 May 2010 18:34:46 +0000
Received: (qmail 17122 invoked from network); 5 May 2010 18:34:45 -0000
Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 5 May 2010 18:34:45 -0000
Date: Wed, 05 May 2010 18:34:00 -0000
From: Daniel Jacobowitz <dan@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,	'Pedro Alves' <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [ARI] Remove all editCase warnings
Message-ID: <20100505183425.GA18375@caradoc.them.org>
Mail-Followup-To: Joel Brobecker <brobecker@adacore.com>,	Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,	'Pedro Alves' <pedro@codesourcery.com>, gdb-patches@sourceware.org
References: <005b01caebe1$2183b890$648b29b0$@muller@ics-cnrs.unistra.fr> <201005050044.28991.pedro@codesourcery.com> <000901caec31$d109e640$731db2c0$@muller@ics-cnrs.unistra.fr> <201005051611.09790.pedro@codesourcery.com> <000001caec6d$59194860$0b4bd920$@muller@ics-cnrs.unistra.fr> <20100505165529.GO2768@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100505165529.GO2768@adacore.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00109.txt.bz2

On Wed, May 05, 2010 at 09:55:29AM -0700, Joel Brobecker wrote:
> >  static void
> > -ada_remove_Xbn_suffix (const char *encoded, int *len)
> > +ada_remove_Xbn_suffix ( /* ARI: editCase function */
> > +		       const char *encoded, int *len)
> 
> I would rather have:
> 
> ada_remove_Xbn_suffix /* ARI: editCase function */
>   (const char *encoded, int *len)
> 
> This applies to the rest of the patch, where we have the comment
> embedded right in the middle of parameter declaration... For instance:

Frankly, I'd rather we just dropped this ARI rule.

-- 
Daniel Jacobowitz
CodeSourcery