From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22245 invoked by alias); 5 May 2010 16:55:54 -0000 Received: (qmail 22235 invoked by uid 22791); 5 May 2010 16:55:52 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 May 2010 16:55:43 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0EFCB2BAAE1; Wed, 5 May 2010 12:55:41 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5Jzq58DcFj1q; Wed, 5 May 2010 12:55:40 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D09C62BAADB; Wed, 5 May 2010 12:55:40 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1C249F58F9; Wed, 5 May 2010 09:55:29 -0700 (PDT) Date: Wed, 05 May 2010 16:55:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: 'Pedro Alves' , gdb-patches@sourceware.org Subject: Re: [ARI] Remove all editCase warnings Message-ID: <20100505165529.GO2768@adacore.com> References: <005b01caebe1$2183b890$648b29b0$@muller@ics-cnrs.unistra.fr> <201005050044.28991.pedro@codesourcery.com> <000901caec31$d109e640$731db2c0$@muller@ics-cnrs.unistra.fr> <201005051611.09790.pedro@codesourcery.com> <000001caec6d$59194860$0b4bd920$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000001caec6d$59194860$0b4bd920$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00099.txt.bz2 > static void > -ada_remove_Xbn_suffix (const char *encoded, int *len) > +ada_remove_Xbn_suffix ( /* ARI: editCase function */ > + const char *encoded, int *len) I would rather have: ada_remove_Xbn_suffix /* ARI: editCase function */ (const char *encoded, int *len) This applies to the rest of the patch, where we have the comment embedded right in the middle of parameter declaration... For instance: > static void > -replace_slotN_contents (char *bundle, long long instr, int slotnum) > +replace_slotN_contents (char *bundle, /* ARI: editCase function */ > + long long instr, int slotnum) What do others think? -- Joel