RE: [ARI] Remove all editCase warnings

Pierre Muller
2010-05-05T21:03:16Z

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Stan Shebs
> Envoyé : Wednesday, May 05, 2010 7:16 PM
> À : Joel Brobecker
> Cc : Pierre Muller; 'Pedro Alves'; gdb-patches@sourceware.org
> Objet : Re: [ARI] Remove all editCase warnings
>
> Joel Brobecker wrote:
> >> static void
> >> -ada_remove_Xbn_suffix (const char *encoded, int *len)
> >> +ada_remove_Xbn_suffix ( /* ARI: editCase function */
> >> + const char *encoded, int *len)
> >>
> >
> > I would rather have:
> >
> > ada_remove_Xbn_suffix /* ARI: editCase function */
> > (const char *encoded, int *len)
> >
>
> I frequently grep for "foo (", so this would cause the function to be
> overlooked. But, fewer grep results means less work when changing the
> code... :-)
That is also what is done inside gdb_ari.sh,
which means that it is not possible to fulfill
Joel's request.

Eliminating the ' (' in the pattern would probably lead to lots of
false positive.

I don't know what to think now...

I fully agree that this is not one of the important
rules, but I hoped that clearing up more fields would make
the ARI more efficient.
Simply removing the rule is not better than
leaving the source code unchanged in my opinion,
but I will follow the consensus if we reach one.

Pierre