Re: [ARI] Remove all editCase warnings

Michael Snyder
2010-05-04T23:51:48Z

Pedro Alves wrote:
> On Wednesday 05 May 2010 00:25:48, Pierre Muller wrote:
>> ARI: Fix editCase.

>
>> * remote.c (set_remote_protocol_Z_packet_cmd): Rename to...
>> (set_remote_protocol_z_packet_cmd): ...this.
>> (show_remote_protocol_Z_packet_cmd): Rename to...
>> (show_remote_protocol_z_packet_cmd): ...this.
>> (store_register_using_P): Rename to...
>> (store_register_using_p): ...this.
>> (store_register_using_G): Rename to...
>> (store_register_using_g): ...this.
>> (remote_store_registers): Adapt to name changes above.
>> (watchpoint_to_Z_packet): Rename to...
>> (watchpoint_to_z_packet): ...this.
>
> I'd rather not. Z, z, P, G, g, are all distinct packets, uppercase
> having the opposite effect of lowercase. Example, you really store
> with G, not g, which is for fetches (note the `fetch_registers_using_g'
> function).

I agree with Pedro and Stan.