From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8853 invoked by alias); 5 May 2010 14:54:34 -0000 Received: (qmail 8833 invoked by uid 22791); 5 May 2010 14:54:32 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 May 2010 14:54:22 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6686C2BAB6E; Wed, 5 May 2010 10:54:20 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id DNMLB8Leln+n; Wed, 5 May 2010 10:54:20 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 346832BAB3E; Wed, 5 May 2010 10:54:20 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2D07EF58F9; Wed, 5 May 2010 07:54:09 -0700 (PDT) Date: Wed, 05 May 2010 14:54:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: 'Pedro Alves' , gdb-patches@sourceware.org Subject: Re: [ARI] Remove all editCase warnings Message-ID: <20100505145409.GN2768@adacore.com> References: <005b01caebe1$2183b890$648b29b0$@muller@ics-cnrs.unistra.fr> <201005050044.28991.pedro@codesourcery.com> <000901caec31$d109e640$731db2c0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000901caec31$d109e640$731db2c0$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00095.txt.bz2 I agree that this is one of these ARI rules which bring little benefit. Or perhaps it was meant to catch CamelCase names rather than any uppercase letter in function names? In any case, here are my 2 cents... > > > * ia64-tdep.c (slotN_contents): Rename to... > > > (slotn_contents): ...this. > > > (replace_slotN_contents): Rename to... > > > (replace_slotn_contents): ...this. > > > > No comments. But I bet whoever wrote this was well aware > > of our coding conventions and still chose an uppercase N. Wow, the file was introduced in March 2000, it's 10 years old! In any case, it was introduced by Kevin Buettner. If I was the author, I'd have no preference over N or n. But if we change it to n, can we add an underscore? slot_n_contents and replace_slot_n_contents? I think that will be slightly easier to read... > - splay_compare_CORE_ADDR_ptr in addrmap.c > there are numerous other functions refereeing to CORE_ADDR type without > using uppercase: It's fine to change it to splay_compare_core_addr_ptr AFAIAC. > - the other two are > proc_get_LDT_entry and procfs_find_LDT_entry in procfs.c > > these two functions are only called by > ps_lgetLDT inside sol-thread.c, which is, according to the comment > required by libthread_db solaris library. > But I do not know if this also justifies propagating the uppercase use > to the called functions in procfs.c No preference on my end. We probably already have some routines that use lowercase accronyms, so it wouldn't be something new. But it would be fine to tolerate the use of uppercase accronyms too (IMO). -- Joel