From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72785-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14124 invoked by alias); 4 May 2010 21:03:24 -0000
Received: (qmail 13971 invoked by uid 22791); 4 May 2010 21:03:23 -0000
X-SWARE-Spam-Status: No, hits=-2.2 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 May 2010 21:03:15 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o44L1YNg018236;	Tue, 4 May 2010 23:01:34 +0200 (CEST)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o44L1XWx030930;	Tue, 4 May 2010 23:01:33 +0200 (CEST)
Date: Tue, 04 May 2010 21:03:00 -0000
Message-Id: <201005042101.o44L1XWx030930@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: pedro@codesourcery.com
CC: gdb-patches@sourceware.org, mark.kettenis@xs4all.nl,        jan.kratochvil@redhat.com
In-reply-to: <201005032200.14472.pedro@codesourcery.com> (message from Pedro	Alves on Mon, 3 May 2010 22:00:14 +0100)
Subject: Re: [patch 1/3] Make obconcat use stdarg
References: <20100430181605.GA19190@host0.dyn.jankratochvil.net> <20100502075217.GA29039@host0.dyn.jankratochvil.net> <201005032019.o43KJ55C028671@glazunov.sibelius.xs4all.nl> <201005032200.14472.pedro@codesourcery.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00078.txt.bz2

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Mon, 3 May 2010 22:00:14 +0100
> 
> On Monday 03 May 2010 21:19:05, Mark Kettenis wrote:
> > ok?
> 
> Yes, of course.
> 
> > 2010-05-03  Mark Kettenis  <kettenis@faure.sibelius.xs4all.nl>
> > 
> >         * remote.c (register_remote_support_xml)
> >         (remote_query_supported_append, remote_query_supported): Add cast
> >         to NULL used as sentinel.
> >         * tracepoint.c (tvariables_info_1): Likewise.
> >         * utils.c (add_internal_problem_command): Likewise.
> 
> 
> > +    remote_support_xml = concat ("xmlRegisters=", xml, (char *)NULL);
> 
> It's way more common in our code base to put a space between cast
> and "castee" (would be `(char *) NULL' in this case).  Not a big
> deal though.

I added the missing spaces and committed the diff.  Thanks!