From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22968 invoked by alias); 4 May 2010 16:23:09 -0000 Received: (qmail 22947 invoked by uid 22791); 4 May 2010 16:23:08 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 May 2010 16:23:00 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o44GMbic005611 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 4 May 2010 12:22:37 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o44GMYr0020222 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 4 May 2010 12:22:36 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o44GMYnn002414; Tue, 4 May 2010 18:22:34 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o44GMXT7002413; Tue, 4 May 2010 18:22:33 +0200 Date: Tue, 04 May 2010 16:23:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: Pierre Muller , gdb@sourceware.org, gdb-patches@sourceware.org Subject: Re: [ARI] Status of ATTRIBUTE_UNUSED in gdb sources Message-ID: <20100504162233.GA1910@host0.dyn.jankratochvil.net> References: <002701caeb90$894ad040$9be070c0$@muller@ics-cnrs.unistra.fr> <20100504153752.GJ2768@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100504153752.GJ2768@adacore.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00072.txt.bz2 On Tue, 04 May 2010 17:37:52 +0200, Joel Brobecker wrote: > make sense unless we use -Wunused-param. And I really don't see how > this switch could help us increase code quality - only extra hassle > trying to silence warnings. While I agree ATTRIBUTE_UNUSED is more hassle than benefit I have to bring up recently -Wunused-param would catch a real bug in an Archer patch (missing "bp->thread = tp->num;"): http://sourceware.org/ml/archer/2010-q2/msg00017.html Regards, Jan