Re: [vxworks 03/14] New module remote-wtx-utils

Tom Tromey
2010-04-26T18:55:44Z

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> This module provides some general-purpose routines which might be
Joel> better off somewhere else... To be discussed individually for each
Joel> routine.

Joel> +have_dos_based_filesystem (void)
Joel> +is_regular_file (const char *name)
Joel> +skip_whitespaces (char *str)

Just "skip_whitespace" sounds more natural to me.
I think "whitespace" is commonly used for both singular and plural.

I think this particular function has been rewritten (inline) many times
throughout gdb...

Joel> +skip_until_character (char *str, char delimiter)
Joel> +skip_until_whitespace (char *str)
Joel> +skip_space_delimited_token (char *str)
Joel> +get_space_delimited_token (char *str, char **token)

I think all of these (including the others above) could be in util.c.

Joel> +void *load_shared_lib (char *lib_name)

Formatting.

Also, this should mention how errors are to be detected.

Joel> +void *get_symbol_from_shared_lib (void *handle, char *symbol)

Ditto.

Tom