From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10747 invoked by alias); 3 May 2010 21:00:38 -0000 Received: (qmail 10724 invoked by uid 22791); 3 May 2010 21:00:37 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 May 2010 21:00:29 +0000 Received: (qmail 3932 invoked from network); 3 May 2010 21:00:27 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 3 May 2010 21:00:27 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch 1/3] Make obconcat use stdarg Date: Mon, 03 May 2010 21:00:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; ) Cc: Mark Kettenis , jan.kratochvil@redhat.com References: <20100430181605.GA19190@host0.dyn.jankratochvil.net> <20100502075217.GA29039@host0.dyn.jankratochvil.net> <201005032019.o43KJ55C028671@glazunov.sibelius.xs4all.nl> In-Reply-To: <201005032019.o43KJ55C028671@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201005032200.14472.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00056.txt.bz2 On Monday 03 May 2010 21:19:05, Mark Kettenis wrote: > ok? Yes, of course. > 2010-05-03 Mark Kettenis > > * remote.c (register_remote_support_xml) > (remote_query_supported_append, remote_query_supported): Add cast > to NULL used as sentinel. > * tracepoint.c (tvariables_info_1): Likewise. > * utils.c (add_internal_problem_command): Likewise. > + remote_support_xml = concat ("xmlRegisters=", xml, (char *)NULL); It's way more common in our code base to put a space between cast and "castee" (would be `(char *) NULL' in this case). Not a big deal though. -- Pedro Alves