From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14295 invoked by alias); 2 May 2010 23:42:05 -0000 Received: (qmail 14286 invoked by uid 22791); 2 May 2010 23:42:04 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 02 May 2010 23:42:01 +0000 Received: (qmail 10356 invoked from network); 2 May 2010 23:41:59 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 2 May 2010 23:41:59 -0000 From: Pedro Alves To: Jan Kratochvil Subject: Re: [patch] ATTR_NORETURN -> ATTRIBUTE_NORETURN unification [Re: [patch] ATTR_* -> ATTRIBUTE_* unification] Date: Sun, 02 May 2010 23:42:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; ) Cc: gdb-patches@sourceware.org, Mark Kettenis References: <20100430181605.GA19190@host0.dyn.jankratochvil.net> <20100502213636.GA21869@host0.dyn.jankratochvil.net> <20100502231941.GA27802@host0.dyn.jankratochvil.net> In-Reply-To: <20100502231941.GA27802@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201005030041.55468.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00023.txt.bz2 On Monday 03 May 2010 00:19:41, Jan Kratochvil wrote: > On Sun, 02 May 2010 23:36:36 +0200, Jan Kratochvil wrote: > > I will post some similar NORETURN + ATTR_NORETURN -> ATTRIBUTE_NORETURN. > > > > Going to drop NORETURN as it is only for gcc < 2.7, ansidecl.h does not > > support it and a missing noreturn flag can only affect code size, performance > > and affect compilation diagnostics. > > error_no_arg was present both in command.h and cli/cli-cmds.h. Moving it the > other way would require #include changes. > > mips_error will start to be effectively declared as noreturn. > > No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu. > This is okay. Thanks for doing this. > Similar work is needed in gdb/gdbserver/. > > doc/ talks about .mh files; but when similar macros are already used from > include/ for bfd/ etc. it probably was inappropriate to do from .mh. Yeah. -- Pedro Alves