From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26207 invoked by alias); 2 May 2010 09:10:25 -0000 Received: (qmail 26188 invoked by uid 22791); 2 May 2010 09:10:22 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 02 May 2010 09:10:16 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4299qcL001927 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 2 May 2010 05:09:52 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o4299o6u029536 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 2 May 2010 05:09:52 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o4299nsu032278; Sun, 2 May 2010 11:09:49 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o4299ntc032277; Sun, 2 May 2010 11:09:49 +0200 Date: Sun, 02 May 2010 09:10:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [patch] testsuite: Simplify + make more safe sepdebug Message-ID: <20100502090948.GA32260@host0.dyn.jankratochvil.net> References: <20100419122801.GA14177@host0.dyn.jankratochvil.net> <20100419162605.GT19194@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100419162605.GT19194@adacore.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00009.txt.bz2 On Mon, 19 Apr 2010 18:26:05 +0200, Joel Brobecker wrote: > > gdb/testsuite/ > > 2010-04-19 Jan Kratochvil > > > > * gdb.base/break-interp.exp: Remove $exec.debug safety removal. > > * gdb.base/sepdebug.exp: Remove .debug subdirectory handling. New > > variable different_dir. Move debugfile into a full directory pathname > > under DIFFERENT_DIR. > > * lib/gdb.exp (separate_debug_filename): Remove. > > (gdb_gnu_strip_debug): No longer call separate_debug_filename. Remove > > variable debug_dir and mkdir of it. Update function comments. > > This does make sense to me - although I don't know off hand the reason > for having initially chosen to put the .debug file in a separate > directory. Maybe there is more to it. > > The patch is fine for me, but let's give it a week to give people a chance > to object.... > > > + # Use the first separate debug info file location searched by GDB so the > > + # run cannot be breaken by some stale file searched with higher precedence. > ^^^^^^^ broken Checked in, with your typo fix: http://sourceware.org/ml/gdb-cvs/2010-05/msg00007.html Thanks, Jan