From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7066 invoked by alias); 2 May 2010 07:52:32 -0000 Received: (qmail 7057 invoked by uid 22791); 2 May 2010 07:52:31 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 02 May 2010 07:52:25 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o427qL5T023724 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 2 May 2010 03:52:21 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o427qI7o018713 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 2 May 2010 03:52:20 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o427qIYt030086; Sun, 2 May 2010 09:52:18 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o427qHol030085; Sun, 2 May 2010 09:52:17 +0200 Date: Sun, 02 May 2010 07:52:00 -0000 From: Jan Kratochvil To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [patch 1/3] Make obconcat use stdarg Message-ID: <20100502075217.GA29039@host0.dyn.jankratochvil.net> References: <20100430181605.GA19190@host0.dyn.jankratochvil.net> <201004301908.o3UJ8mGf006742@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201004301908.o3UJ8mGf006742@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00008.txt.bz2 On Fri, 30 Apr 2010 21:08:48 +0200, Mark Kettenis wrote: > I'm afraid you'll need an explicit cast for the NULLs used as the > sentinel value There is also needed a fix for cases already protected by ATTRIBUTE_SENTINEL and already using just the bare "NULL" sentinel: concat reconcat concat_length concat_copy concat_copy2 fbsd-nat.c by Mark Kettenis 50e330a0 2004-09-19 (reconcat has ATTRIBUTE_SENTINEL since bf7628f0 2004-09-05) psargs = reconcat (psargs, psargs, " ", get_inferior_args (), NULL); remote.c [HAVE_LIBEXPAT] remote_support_xml = concat ("xmlRegisters=", xml, NULL); p = concat (remote_support_xml, ",", xml, NULL); remote.c d5ea7042 2010-03-30 char *p = concat (msg, ";", append, NULL); char *p = concat ("qSupported:", q, NULL); name = concat ("$", tsv->name, NULL); utils.c 8b58bcf2 2009-01-26 concat ("maintenance set ", problem->name, " ", NULL), concat ("maintenance show ", problem->name, " ", NULL), Nobody has noticed this problem since 2004. > , otherwise platforms that > > #define NULL 0L So DJGPP is not such platform, which other platforms? FreeBSD apparently also does not have this problem. Thanks, Jan