From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72697-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8357 invoked by alias); 30 Apr 2010 19:09:13 -0000
Received: (qmail 8301 invoked by uid 22791); 30 Apr 2010 19:09:11 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Apr 2010 19:09:07 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o3UJ8nBg007250;	Fri, 30 Apr 2010 21:08:49 +0200 (CEST)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o3UJ8mGf006742;	Fri, 30 Apr 2010 21:08:48 +0200 (CEST)
Date: Fri, 30 Apr 2010 19:09:00 -0000
Message-Id: <201004301908.o3UJ8mGf006742@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jan.kratochvil@redhat.com
CC: gdb-patches@sourceware.org
In-reply-to: <20100430181605.GA19190@host0.dyn.jankratochvil.net> (message	from Jan Kratochvil on Fri, 30 Apr 2010 20:16:05 +0200)
Subject: Re: [patch 1/3] Make obconcat use stdarg
References:  <20100430181605.GA19190@host0.dyn.jankratochvil.net>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg01016.txt.bz2

> Date: Fri, 30 Apr 2010 20:16:05 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> 
> Hi,
> 
> __attribute__ ((sentinel)) availability for gcc >= 4.0 I have copied from
> <glib-2.0/glib/gmacros.h>.  It roughly matches the GCC ChangeLog dates.

The OpenBSD system compile, which is based on GCC 3.3.5, already has
the sentinel attribute.

> No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu for the whole
> patchset.

I'm afraid you'll need an explicit cast for the NULLs used as the
sentinel value, otherwise platforms that

  #define NULL 0L

will generate warnings like:

  sentinel.c: In function 'foo':
  sentinel.c:8: warning: missing sentinel in function call

and with -Werror, that's not a good :(.