From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29430 invoked by alias); 27 Apr 2010 20:32:17 -0000 Received: (qmail 29421 invoked by uid 22791); 27 Apr 2010 20:32:16 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Apr 2010 20:32:12 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3RKWBiu014958 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 27 Apr 2010 16:32:11 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3RKW8Vd003237 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 27 Apr 2010 16:32:10 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o3RKW8RL013417; Tue, 27 Apr 2010 22:32:08 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o3RKW8Cg013416; Tue, 27 Apr 2010 22:32:08 +0200 Date: Tue, 27 Apr 2010 20:32:00 -0000 From: Jan Kratochvil To: Chris Moller Cc: "gdb-patches@sourceware.org" Subject: Re: pr 11543 using-directive does not autocomplete Message-ID: <20100427203207.GA12825@host0.dyn.jankratochvil.net> References: <4BD725BC.2090709@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BD725BC.2090709@redhat.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00925.txt.bz2 On Tue, 27 Apr 2010 19:58:20 +0200, Chris Moller wrote: > Attached patch fixes this, but here's a question: Is it possible to > have multiple name qualifications like "A::B::whatever"? Yes. Unfortunately your patch has a regression even for single-namespace case: ------------------------------------------------------------------------------ namespace A { int variableq = 1; namespace B { int variabler = 2; } } int main (void) { return A::variableq + A::B::variabler; } ------------------------------------------------------------------------------ (gdb) p var -> (gdb) p variableq No symbol "variableq" in current context. In this case current FSF GDB HEAD behavior is the only correct one. The completion patch must follow the existing / non-existing "using namespace" directives. The patch must be integrated with `struct using_direct' lists tracked by Sami Wagiaalla's using_directive infrastructure. Thanks for picking this up. Thanks, Jan