From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12390 invoked by alias); 27 Apr 2010 16:05:40 -0000 Received: (qmail 12273 invoked by uid 22791); 27 Apr 2010 16:05:38 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Apr 2010 16:05:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 99A942BAB34; Tue, 27 Apr 2010 12:05:26 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id o2mCDELikkyK; Tue, 27 Apr 2010 12:05:26 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5EBBA2BAB7A; Tue, 27 Apr 2010 12:05:26 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5BC1EF5896; Tue, 27 Apr 2010 09:05:23 -0700 (PDT) Date: Tue, 27 Apr 2010 16:05:00 -0000 From: Joel Brobecker To: Mihail Zenkov Cc: tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: D language support Message-ID: <20100427160523.GD2951@adacore.com> References: <20100415012124.91ce1769.mihai.zenkov@gmail.com> <20100421025919.ad3a0830.mihai.zenkov@gmail.com> <20100421155657.GA19194@adacore.com> <20100422030910.7e84f7ea.mihai.zenkov@gmail.com> <20100422004441.GE19194@adacore.com> <20100422045136.bc397747.mihai.zenkov@gmail.com> <20100424030441.81b6b66b.mihai.zenkov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100424030441.81b6b66b.mihai.zenkov@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00908.txt.bz2 > +static const char *mangled_str; > +/* Temporary obstack used for holding strings. */ > +static struct obstack tempbuf; Can you remove the declaration of these globals? They shouldn't be necessary anymore... Otherwise, the rest looks OK to me. -- Joel