From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7866 invoked by alias); 26 Apr 2010 11:26:50 -0000 Received: (qmail 7856 invoked by uid 22791); 26 Apr 2010 11:26:49 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Apr 2010 11:26:43 +0000 Received: (qmail 23111 invoked from network); 26 Apr 2010 11:26:41 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Apr 2010 11:26:41 -0000 From: Pedro Alves To: "Pierre Muller" Subject: Re: [RFA- v2] Remove CANNOT_STEP_HW_WATCHPOINTS related code (was fix for bug 11531) Date: Mon, 26 Apr 2010 11:26:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; ) Cc: "'Eli Zaretskii'" , gdb-patches@sourceware.org, "'Joel Brobecker'" References: <000301cae303$d6d068b0$84713a10$@muller@ics-cnrs.unistra.fr> <201004252110.20098.pedro@codesourcery.com> <003c01cae515$41e52290$c5af67b0$@muller@ics-cnrs.unistra.fr> In-Reply-To: <003c01cae515$41e52290$c5af67b0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201004261226.38885.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00859.txt.bz2 On Monday 26 April 2010 08:51:18, Pierre Muller wrote: > Is this patch OK? This is going in circles, but, why didn't you remove the macro definition and the whole comment around it from the nm file? The goal is remove the whole workaround, so you should remove that too. The goal of the exercise is to keep each patch self-contained. I know you'll remove the nm file afterwards, but, let's pretend you wouldn't, or that someone would reject that patch of yours for some reason we haven't thought of yet --- you'll still want the macro and the comments around it to, _not_ end up defined in there after this patch. On Monday 26 April 2010 08:51:18, Pierre Muller wrote: > In that case, the configure.tgt script should probably report > that Solaris versions <= 2.7 are not supported anymore. > This is what I added to configure.tgt below. ... > -i[34567]86-*-solaris*) > - # Target: Solaris x86 > +i[34567]86-*-solaris2.[8-9] ) > + # Target: Solaris x86, only versions 2.8 and 2.9 > + # Versions <= 2.7 suffer a bug that was handled in older versions of > > + # GDB, but that code was removed. It may still work, provided the user doesn't set watchpoints... In any case, this won't prevent someone building gdb on such solaris', because you'll still hit the "i[34567]86-*-*)" case below (and --enable-targets=all will still build the files you're skipping anyway), leaving the user with a built, but very crippled GDB, with no hint where to look at. I suggest leaving this change out of the patch and focusing on a single thing at a time, otherwise we'll never get this done. -- Pedro Alves