From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4175 invoked by alias); 23 Apr 2010 20:07:34 -0000 Received: (qmail 4163 invoked by uid 22791); 23 Apr 2010 20:07:33 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Apr 2010 20:07:30 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AD5232BACD3; Fri, 23 Apr 2010 16:07:28 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rWkh7-Fh+8vw; Fri, 23 Apr 2010 16:07:28 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9D5EE2BACE4; Fri, 23 Apr 2010 16:07:27 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0052AF5895; Fri, 23 Apr 2010 13:07:26 -0700 (PDT) Date: Fri, 23 Apr 2010 20:07:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [patch] Fix dwarf2read to crash again Message-ID: <20100423200726.GQ19194@adacore.com> References: <20100421091303.GA19378@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00813.txt.bz2 > My conclusion from these cases is that gdb ought to fail gracefully. Agreed. > I suspect we should even go so far as to wrap process_die (or possibly > some more appropriate function) in a TRY_CATCH and skip DIEs that > confuse gdb. Sounds like a good idea to me. -- Joel