From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9967 invoked by alias); 23 Apr 2010 20:15:14 -0000 Received: (qmail 9952 invoked by uid 22791); 23 Apr 2010 20:15:12 -0000 X-SWARE-Spam-Status: No, hits=0.2 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED,RCVD_NUMERIC_HELO,SPF_HELO_PASS,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from lo.gmane.org (HELO lo.gmane.org) (80.91.229.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Apr 2010 20:15:06 +0000 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1O5PHC-0006y0-Hw for gdb-patches@sources.redhat.com; Fri, 23 Apr 2010 22:15:02 +0200 Received: from 190.138.33.165 ([190.138.33.165]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 23 Apr 2010 22:15:02 +0200 Received: from llucax by 190.138.33.165 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 23 Apr 2010 22:15:02 +0200 To: gdb-patches@sources.redhat.com connect(): No such file or directory From: Leandro Lucarella Subject: Re: D language support Date: Fri, 23 Apr 2010 20:15:00 -0000 Message-ID: <20100423193659.GA5342@llucax.com.ar> References: <20100109142327.GC2007@adacore.com> <20100113064026.14f75ff2.mihai.zenkov@gmail.com> <20100415012124.91ce1769.mihai.zenkov@gmail.com> <20100421025919.ad3a0830.mihai.zenkov@gmail.com> <20100421155657.GA19194@adacore.com> <20100422030910.7e84f7ea.mihai.zenkov@gmail.com> <20100422004441.GE19194@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline In-Reply-To: X-Paranoid: Just because you're paranoid, don't mean they're not after you. User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00815.txt.bz2 Tom Tromey, el 23 de abril a las 12:09 me escribiste: > >>>>> "Joel" == Joel Brobecker writes: > > Joel> Although making the variable static limits the damage, I pretty strongly > Joel> disagree that having this inter-routine global makes the code more > Joel> readable. But, as I said, I don't see this as a blocking problem because > Joel> it's localized to an area that I hope will require little attention from > Joel> anyone but you; so I am happy to let it go provided that another Global > Joel> Maintainer says it's OK - I'll try to remember to ask Tom for his take > Joel> on it, if no one else provides an opinion... > > I took another look at it. > > I agree with Joel. In this case, the variables in question could easily > be replaced with function arguments. > > I realize this means adding a bunch of "*"s all over the place, which is > kind of ugly. But the flip side is that globals make functions more > difficult to understand in isolation. > > I also realize that this sort of thing appears elsewhere. I'd rather we > not emulate bad decisions in new code, though. > > I saw a couple more style nits too, more in the next note. Is the indent program invoked with -gnu option enough to fix the style nits or GDB has its own rules? It might save some time to everybody =) Thanks to all the people involved in the patch review process BTW. -- Leandro Lucarella (AKA luca) http://llucax.com.ar/ ---------------------------------------------------------------------- GPG Key: 5F5A8D05 (F8CD F9A7 BF00 5431 4145 104C 949E BFB6 5F5A 8D05) ---------------------------------------------------------------------- El amor es como una reina ortopédica. -- Poroto