From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72443-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3013 invoked by alias); 22 Apr 2010 19:48:25 -0000
Received: (qmail 3004 invoked by uid 22791); 22 Apr 2010 19:48:24 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 	tests=BAYES_00,TW_EG,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Apr 2010 19:48:19 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o3MJmBA3008493; 	Thu, 22 Apr 2010 21:48:11 +0200 (CEST)
Received: (from kettenis@localhost) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o3MJmAnH030821; 	Thu, 22 Apr 2010 21:48:10 +0200 (CEST)
Date: Thu, 22 Apr 2010 19:48:00 -0000
Message-Id: <201004221948.o3MJmAnH030821@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: hjl.tools@gmail.com
CC: gdb-patches@sourceware.org, mark.kettenis@xs4all.nl
In-reply-to: <20100421230929.GA11193@intel.com> (hongjiu.lu@intel.com)
Subject: Re: PATCH: Remove amd64_linux_gregset64_reg_offset and regmap
References:  <20100421230929.GA11193@intel.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00762.txt.bz2

> Date: Wed, 21 Apr 2010 16:09:29 -0700
> From: "H.J. Lu" <hongjiu.lu@intel.com>
> 
> Hi,
> 
> As we have discussed, this patch removes amd64_linux_gregset64_reg_offset
> and regmap from i386/amd64 Linux targets.  OK to install?

The amd64 bits are ok.  A small issue with the i386 bits below.
> diff --git a/gdb/i386-linux-nat.c b/gdb/i386-linux-nat.c
> index d559811..35bc3bd 100644
> --- a/gdb/i386-linux-nat.c
> +++ b/gdb/i386-linux-nat.c
> @@ -245,18 +228,19 @@ void
>  fill_gregset (const struct regcache *regcache,
>  	      elf_gregset_t *gregsetp, int regno)
>  {
> -  elf_greg_t *regp = (elf_greg_t *) gregsetp;
> +  gdb_byte *regp = (gdb_byte *) gregsetp;
>    int i;
>  
>    for (i = 0; i < I386_NUM_GREGS; i++)
>      if (regno == -1 || regno == i)
> -      regcache_raw_collect (regcache, i, regp + regmap[i]);
> +      regcache_raw_collect (regcache, i,
> +			    regp + i386_linux_gregset_reg_offset[i]);
>  
>    if ((regno == -1 || regno == I386_LINUX_ORIG_EAX_REGNUM)
>        && I386_LINUX_ORIG_EAX_REGNUM
>  	   < gdbarch_num_regs (get_regcache_arch (regcache)))
>      regcache_raw_collect (regcache, I386_LINUX_ORIG_EAX_REGNUM,
> -			  regp + ORIG_EAX);
> +			  regp + 4 * ORIG_EAX);

I think this should use an offset from i386_linux_gregset_reg_offset[]
as well.