From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72442-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32395 invoked by alias); 22 Apr 2010 19:43:39 -0000
Received: (qmail 32385 invoked by uid 22791); 22 Apr 2010 19:43:38 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Apr 2010 19:43:34 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o3MJhSje032621; 	Thu, 22 Apr 2010 21:43:28 +0200 (CEST)
Received: (from kettenis@localhost) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o3MJhRFi014239; 	Thu, 22 Apr 2010 21:43:27 +0200 (CEST)
Date: Thu, 22 Apr 2010 19:43:00 -0000
Message-Id: <201004221943.o3MJhRFi014239@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: hjl.tools@gmail.com
CC: gdb-patches@sourceware.org
In-reply-to: <t2y6dc9ffc81004201445iedc8c3b6x76b7b784eecfd858@mail.gmail.com> 	(hjl.tools@gmail.com)
Subject: Re: [PATCH] Fix Linux/i386 register set size
References: <201004201942.o3KJgtMB025587@glazunov.sibelius.xs4all.nl> <t2y6dc9ffc81004201445iedc8c3b6x76b7b784eecfd858@mail.gmail.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00761.txt.bz2

> Date: Tue, 20 Apr 2010 14:45:19 -0700
> From: "H.J. Lu" <hjl.tools@gmail.com>
> 
> On Tue, Apr 20, 2010 at 12:42 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> > Should be 68.  Confusion is probably caused by the fact that the note
> > size is 144, and that the amd64 register set is also 144.  The fact
> > that the GDB gcore produces wrong core files in the 32x64 case doesn't
> > help either.
> >
> > Committed.
> >
> >
> > 2010-04-20  Mark Kettenis  <kettenis@gnu.org>
> >
> >        * i386-linux-tdep.c (i386_linux_regset_sections): Size of the
> >        general-purpose register set should be 68 instead of 144.
> >        (i386_linux_sse_regset_sections): Likewise.
> >        (i386_linux_avx_regset_sections): Likewise.
> >
> >
> 
> On Linux, ".reg" section is a special case. Its size is ignored.
> See linux_nat_do_thread_registers for details. You can set
> it to anything and it doesn't make a difference.

Right.  No excuse not the correct the mistake though.